Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOPE-242: feature use index #49

Merged
merged 19 commits into from
Sep 18, 2024
Merged

DOPE-242: feature use index #49

merged 19 commits into from
Sep 18, 2024

Conversation

jansigi
Copy link
Collaborator

@jansigi jansigi commented Aug 16, 2024

Added interface IBucket. This Interface is used everywhere you can use a normal Bucket (UnaliasedBucket/AliasedBucket) and the UseIndex and UseKeys.

Added interface IBucket. This Interface is used everywhere you can use a normal Bucket (UnaliasedBucket/AliasedBucket) and the UseIndex and UseKeys.
# Conflicts:
#	core/src/main/kotlin/ch/ergon/dope/resolvable/clause/model/JoinClause.kt
Copy link
Collaborator

@martinagallati-ergon martinagallati-ergon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mainly questions about my understanding of things. I really like the new approach of using use keys / index in the from call 🙂

Copy link
Collaborator

@martinagallati-ergon martinagallati-ergon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@jansigi
Copy link
Collaborator Author

jansigi commented Aug 27, 2024

Implement Interfaces from Confluence

@ergon ergon deleted a comment from martinagallati-ergon Aug 27, 2024
# Conflicts:
#	core/src/main/kotlin/ch/ergon/dope/resolvable/clause/model/DeleteClause.kt
#	core/src/main/kotlin/ch/ergon/dope/resolvable/clause/model/JoinClause.kt
#	core/src/main/kotlin/ch/ergon/dope/resolvable/clause/model/UpdateClause.kt
#	core/src/main/kotlin/ch/ergon/dope/resolvable/clause/model/UseKeysClause.kt
#	core/src/main/kotlin/ch/ergon/dope/resolvable/expression/unaliased/type/function/stringfunction/TokensExpression.kt
#	core/src/main/kotlin/ch/ergon/dope/resolvable/fromable/AliasedSelectClause.kt
#	core/src/main/kotlin/ch/ergon/dope/resolvable/fromable/Bucket.kt
#	core/src/test/kotlin/ch/ergon/dope/buildTest/UseTest.kt
#	core/src/test/kotlin/ch/ergon/dope/resolvable/clause/UseKeysClauseTest.kt
#	crystal-map-connector/src/test/kotlin/ch/ergon/dope/extensions/clause/DeleteClauseTest.kt
#	crystal-map-connector/src/test/kotlin/ch/ergon/dope/extensions/clause/SelectClauseTest.kt
#	crystal-map-connector/src/test/kotlin/ch/ergon/dope/extensions/clause/UpdateClauseTest.kt
@jansigi jansigi requested a review from pgruntz August 29, 2024 06:53
# Conflicts:
#	core/src/main/kotlin/ch/ergon/dope/resolvable/clause/model/DeleteClause.kt
#	core/src/main/kotlin/ch/ergon/dope/resolvable/clause/model/JoinClause.kt
#	core/src/main/kotlin/ch/ergon/dope/resolvable/clause/model/UpdateClause.kt
#	core/src/main/kotlin/ch/ergon/dope/resolvable/fromable/Bucket.kt
#	crystal-map-connector/src/main/kotlin/ch/ergon/dope/extension/clause/DeleteClause.kt
#	crystal-map-connector/src/main/kotlin/ch/ergon/dope/extension/clause/SelectClause.kt
#	crystal-map-connector/src/main/kotlin/ch/ergon/dope/extension/clause/UpdateClause.kt
#	crystal-map-connector/src/test/kotlin/ch/ergon/dope/extensions/clause/UpdateClauseTest.kt
@jansigi jansigi merged commit aa7c947 into main Sep 18, 2024
1 check passed
@jansigi jansigi deleted the feature/dope-242-use-index branch September 18, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants