-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOPE-242: feature use index #49
Conversation
Added interface IBucket. This Interface is used everywhere you can use a normal Bucket (UnaliasedBucket/AliasedBucket) and the UseIndex and UseKeys.
# Conflicts: # core/src/main/kotlin/ch/ergon/dope/resolvable/clause/model/JoinClause.kt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mainly questions about my understanding of things. I really like the new approach of using use keys / index in the from
call 🙂
core/src/main/kotlin/ch/ergon/dope/resolvable/fromable/UseKeys.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/ch/ergon/dope/resolvable/clause/model/UpdateClause.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/ch/ergon/dope/resolvable/fromable/UseIndex.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/ch/ergon/dope/resolvable/fromable/UseIndex.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/ch/ergon/dope/resolvable/fromable/UseIndex.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/ch/ergon/dope/resolvable/clause/model/DeleteClause.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/ch/ergon/dope/resolvable/fromable/UseKeys.kt
Outdated
Show resolved
Hide resolved
crystal-map-connector/src/main/kotlin/ch/ergon/dope/extension/clause/SelectClause.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/ch/ergon/dope/resolvable/fromable/UseIndex.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/ch/ergon/dope/resolvable/fromable/UseIndex.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/ch/ergon/dope/resolvable/fromable/UseIndex.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/ch/ergon/dope/resolvable/fromable/UseIndex.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/ch/ergon/dope/resolvable/fromable/UseIndex.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Implement Interfaces from Confluence |
# Conflicts: # core/src/main/kotlin/ch/ergon/dope/resolvable/clause/model/DeleteClause.kt # core/src/main/kotlin/ch/ergon/dope/resolvable/clause/model/JoinClause.kt # core/src/main/kotlin/ch/ergon/dope/resolvable/clause/model/UpdateClause.kt # core/src/main/kotlin/ch/ergon/dope/resolvable/clause/model/UseKeysClause.kt # core/src/main/kotlin/ch/ergon/dope/resolvable/expression/unaliased/type/function/stringfunction/TokensExpression.kt # core/src/main/kotlin/ch/ergon/dope/resolvable/fromable/AliasedSelectClause.kt # core/src/main/kotlin/ch/ergon/dope/resolvable/fromable/Bucket.kt # core/src/test/kotlin/ch/ergon/dope/buildTest/UseTest.kt # core/src/test/kotlin/ch/ergon/dope/resolvable/clause/UseKeysClauseTest.kt # crystal-map-connector/src/test/kotlin/ch/ergon/dope/extensions/clause/DeleteClauseTest.kt # crystal-map-connector/src/test/kotlin/ch/ergon/dope/extensions/clause/SelectClauseTest.kt # crystal-map-connector/src/test/kotlin/ch/ergon/dope/extensions/clause/UpdateClauseTest.kt
core/src/main/kotlin/ch/ergon/dope/resolvable/clause/model/DeleteClause.kt
Show resolved
Hide resolved
core/src/main/kotlin/ch/ergon/dope/resolvable/QueryStringBuilder.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/ch/ergon/dope/resolvable/fromable/UseIndex.kt
Outdated
Show resolved
Hide resolved
# Conflicts: # core/src/main/kotlin/ch/ergon/dope/resolvable/clause/model/DeleteClause.kt # core/src/main/kotlin/ch/ergon/dope/resolvable/clause/model/JoinClause.kt # core/src/main/kotlin/ch/ergon/dope/resolvable/clause/model/UpdateClause.kt # core/src/main/kotlin/ch/ergon/dope/resolvable/fromable/Bucket.kt # crystal-map-connector/src/main/kotlin/ch/ergon/dope/extension/clause/DeleteClause.kt # crystal-map-connector/src/main/kotlin/ch/ergon/dope/extension/clause/SelectClause.kt # crystal-map-connector/src/main/kotlin/ch/ergon/dope/extension/clause/UpdateClause.kt # crystal-map-connector/src/test/kotlin/ch/ergon/dope/extensions/clause/UpdateClauseTest.kt
Added interface IBucket. This Interface is used everywhere you can use a normal Bucket (UnaliasedBucket/AliasedBucket) and the UseIndex and UseKeys.